ModdingRX/YimMenu
Archived
1
0
Fork 0
Code Actions Releases Activity

feat(ExceptionHandler): Don't log repeating exceptions (#1244)

Browse Source
This commit is contained in:
Andreas Maerten 2023-04-16 00:20:48 +02:00 committed by GitHub
parent 60e1c2e3c6
commit fc52860e02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 389 additions and 366 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/common.hpp
View File

@ -35,6 +35,7 @@
#include <functional>
#include <utility>
#include <set>
#include <stack>
#include <vector>

20
src/logger/exception_handler.cpp
View File

@ -6,6 +6,14 @@
namespace big
{
inline auto hash_stack_trace(std::vector<uint64_t> stack_trace)
{
auto data = reinterpret_cast<const char*>(stack_trace.data());
std::size_t size = stack_trace.size() * sizeof(uint64_t);
return std::hash<std::string_view>()({ data, size });
}
exception_handler::exception_handler()
{
SetErrorMode(0);
@ -14,8 +22,8 @@ namespace big
exception_handler::~exception_handler()
{
// passing NULL / 0 will make it go back to normal exception handling
SetUnhandledExceptionFilter(0);
// passing nullptr will make it go back to normal exception handling
SetUnhandledExceptionFilter(nullptr);
}
inline static stack_trace trace;
@ -25,9 +33,17 @@ namespace big
if (exception_code == EXCEPTION_BREAKPOINT || exception_code == DBG_PRINTEXCEPTION_C || exception_code == DBG_PRINTEXCEPTION_WIDE_C)
return EXCEPTION_CONTINUE_SEARCH;
static std::set<std::size_t> logged_exceptions;
trace.new_stack_trace(exception_info);
const auto trace_hash = hash_stack_trace(trace.frame_pointers());
if (const auto it = logged_exceptions.find(trace_hash); it == logged_exceptions.end())
{
LOG(FATAL) << trace;
logged_exceptions.insert(trace_hash);
}
ZyanU64 opcode_address = exception_info->ContextRecord->Rip;
ZydisDisassembledInstruction instruction;
ZydisDisassembleIntel(ZYDIS_MACHINE_MODE_LONG_64, opcode_address, reinterpret_cast<void*>(opcode_address), 32, &instruction);

5
src/logger/stack_trace.cpp
View File

@ -19,6 +19,11 @@ namespace big
SymCleanup(GetCurrentProcess());
}
const std::vector<uint64_t>& stack_trace::frame_pointers()
{
return m_frame_pointers;
}
void stack_trace::new_stack_trace(EXCEPTION_POINTERS* exception_info)
{
static std::mutex m;

1
src/logger/stack_trace.hpp
View File

@ -9,6 +9,7 @@ namespace big
stack_trace();
virtual ~stack_trace();
const std::vector<uint64_t>& frame_pointers();
void new_stack_trace(EXCEPTION_POINTERS* exception_info);
std::string str() const;