Remove Unknown Player OOM Kick False Positives (#3170)

This commit is contained in:
Ryan 2024-05-24 17:19:32 -04:00 committed by GitHub
parent a6e7eb54b6
commit ffbd55703d

View File

@ -240,14 +240,14 @@ namespace big
case rage::eNetMessage::MsgScriptMigrateHost: return true; case rage::eNetMessage::MsgScriptMigrateHost: return true;
case rage::eNetMessage::MsgRadioStationSyncRequest: case rage::eNetMessage::MsgRadioStationSyncRequest:
{ {
static rate_limiter unk_player_radio_requests{2s, 2}; static rate_limiter unk_player_radio_requests{1s, 6};
if (unk_player_radio_requests.process()) if (unk_player_radio_requests.process())
{ {
if (unk_player_radio_requests.exceeded_last_process()) if (unk_player_radio_requests.exceeded_last_process())
{ {
// Make a translation for this new OOM kick protection // Make a translation for this new OOM kick protection
g_notification_service.push_error("PROTECTIONS"_T.data(), "OOM_KICK"_T.data()); g_notification_service.push_error("PROTECTIONS"_T.data(), "OOM_KICK_UNK"_T.data());
} }
return true; return true;
} }
@ -259,7 +259,7 @@ namespace big
if (g.debug.logs.packet_logs) [[unlikely]] if (g.debug.logs.packet_logs) [[unlikely]]
{ {
if (g.debug.logs.packet_logs == 1 || //ALL if (g.debug.logs.packet_logs == 1 || //ALL
(g.debug.logs.packet_logs == 2 && msgType != rage::eNetMessage::MsgCloneSync && msgType != rage::eNetMessage::MsgPackedCloneSyncACKs && msgType != rage::eNetMessage::MsgPackedEvents && msgType != rage::eNetMessage::MsgPackedReliables && msgType != rage::eNetMessage::MsgPackedEventReliablesMsgs && msgType != rage::eNetMessage::MsgNetArrayMgrUpdate && msgType != rage::eNetMessage::MsgNetArrayMgrSplitUpdateAck && msgType != rage::eNetMessage::MsgNetArrayMgrUpdateAck && msgType != rage::eNetMessage::MsgScriptHandshakeAck && msgType != rage::eNetMessage::MsgScriptHandshake && msgType != rage::eNetMessage::MsgScriptJoin && msgType != rage::eNetMessage::MsgScriptJoinAck && msgType != rage::eNetMessage::MsgScriptJoinHostAck && msgType != rage::eNetMessage::MsgRequestObjectIds && msgType != rage::eNetMessage::MsgInformObjectIds && msgType != rage::eNetMessage::MsgNetTimeSync)) //FILTERED (g.debug.logs.packet_logs == 2 && msgType != rage::eNetMessage::MsgCloneSync && msgType != rage::eNetMessage::MsgPackedCloneSyncACKs && msgType != rage::eNetMessage::MsgPackedEvents && msgType != rage::eNetMessage::MsgPackedReliables && msgType != rage::eNetMessage::MsgPackedEventReliablesMsgs && msgType != rage::eNetMessage::MsgNetArrayMgrUpdate && msgType != rage::eNetMessage::MsgNetArrayMgrSplitUpdateAck && msgType != rage::eNetMessage::MsgNetArrayMgrUpdateAck && msgType != rage::eNetMessage::MsgScriptHandshakeAck && msgType != rage::eNetMessage::MsgScriptHandshake && msgType != rage::eNetMessage::MsgScriptJoin && msgType != rage::eNetMessage::MsgScriptJoinAck && msgType != rage::eNetMessage::MsgScriptJoinHostAck && msgType != rage::eNetMessage::MsgRequestObjectIds && msgType != rage::eNetMessage::MsgInformObjectIds && msgType != rage::eNetMessage::MsgNetTimeSync)) //FILTERED
{ {
const char* packet_type = "<UNKNOWN>"; const char* packet_type = "<UNKNOWN>";
for (const auto& p : packet_types) for (const auto& p : packet_types)